Memory Wiki

Let me continue reading the rest of the plans and explore the existing reference modules.

Let me look at existing reference modules for patterns.

Let me check the existing migration SQL path and the webhook_handler tests to complete my reference understanding.

Now I have a thorough understanding of all patterns. Let me build both modules. I'll start creating files in parallel batches.

Now creating the BillingAdminService and BillingAdminModule:

Now creating T19 test files and T20 module files in parallel:

Now let me verify T19 PHP files and start creating T20 module files:

All T19 PHP files pass syntax check. Now creating T20 (Rate Limiter) module:

Now creating the main RateLimiter, Migration, Module, and README:

All T20 source files pass syntax checks. Now creating migration SQL, README, and test files:

Now verifying all PHP files pass syntax check:

Let me verify the final file structures:

Let me do a quick test count to verify the minimums:

Both modules built successfully. Here's the summary: --- ## Summary ### T19 — Billing Admin (`/root/profe-modules/billing_admin/`) **Files created (13):** | File | Purpose | |------|---------| | `composer.json` | Module metadata, deps on stripe-service, order-management | | `module.json` | Module name + 6 declared dependencies | | `README.md` | Purpose, endpoints, events, tables, config | | `src/.../BillingAdminInterface.php` | Service contract (8 methods) | | `src/.../BillingAdminService.php` | Implementation — FAULT-008 injected deps, FAULT-002 documented direct `profe_users` queries | | `src/.../BillingAdminModule.php` | ModuleInstanceInterface — 8 REST routes, FAULT-004 CSRF on POST, FAULT-01 closure | | `src/.../Repository/BillingAdminRepository.php` | DB ops on `profe_orders`, `profe_subscriptions`, `profe_webhook_events`, `profe_users` — FAULT-04/05 bare tables + prepared statements | | `src/.../Exception/BillingAdminException.php` | Typed exception | | `tests/Fixture/BillingAdminFixtures.php` | Test data | | `tests/Unit/BillingAdminServiceTest.php` | 12 tests | | `tests/Unit/BillingAdminModuleTest.php` | 4 tests | | `tests/Unit/BillingAdminRepositoryTest.php` | 6 tests | | `tests/Integration/BillingAdminIntegrationTest.php` | 2 tests | **Total tests: 24** ✓ (≥12 minimum) **Tables read:** `profe_orders`, `profe_subscriptions`, `profe_webhook_events`, `profe_users` (no new tables) **Key fault compliance:** - FAULT-004: POST `/subscriptions/{userId}/cancel` uses `checkAdminAccessWithCsrf()` which calls `requireValidNonce()` - FAULT-002/007: All direct `profe_users` queries documented with FAULT-002 workaround comments - FAULT-008: Constructor receives all 6 declared deps; verified via reflection test - FAULT-01: Factory closures capture `$c`, never store container --- ### T20 — Rate Limiter (`/root/profe-modules/rate_limiter/`) **Files created (16):** | File | Purpose | |------|---------| | `composer.json` | Module metadata, requires ext-redis | | `module.json` | Module name + 3 declared dependencies | | `README.md` | Purpose, config keys, events, Redis/DB behavior, 429 format | | `src/.../RateLimiterInterface.php` | Service contract (6 methods) | | `src/.../RateLimiter.php` | Redis-backed token bucket + DB fallback — FAULT-008 injected deps | | `src/.../RateLimiterModule.php` | ModuleInstanceInterface — 2 admin routes, `rest_pre_dispatch` middleware, endpoint-specific thresholds, FAULT-004 CSRF on DELETE | | `src/.../RateLimitKeyBuilder.php` | Key construction utility (`forIp`, `forUser`, `forUserAndIp`) | | `src/.../Repository/RateLimitRepository.php` | DB ops on `profe_rate_limits` — FAULT-04/05 bare tables + prepared statements | | `src/.../Migration/CreateRateLimitsMigration.php` | **FAULT-006**: PHP migration class with `up()`/`down()` SQL | | `src/.../Exception/RateLimiterException.php` | Typed exception | | `tests/Fixture/RateLimiterFixtures.php` | Test data | | `tests/Unit/RateLimiterTest.php` | 10 tests | | `tests/Unit/RateLimiterModuleTest.php` | 5 tests | | `tests/Unit/RateLimitRepositoryTest.php` | 6 tests | | `tests/Unit/RateLimitKeyBuilderTest.php` | 3 tests | | `tests/Integration/RateLimiterIntegrationTest.php` | 2 tests | **Resource also created:** - `/root/profe-modules/migrations/007_create_profe_rate_limits.sql` — migration SQL matching the PHP migration class **Total tests: 26** ✓ (≥12 minimum) **Key fault compliance:** - FAULT-004: DELETE `/admin/rate-limits/{key}` uses `checkAdminAccessWithCsrf()` - FAULT-006: PHP migration class `CreateRateLimitsMigration` exists alongside SQL file - FAULT-008: Constructor receives all 4 declared deps (Redis, Repository, ConfigManager, EventBus) - HC-02: Redis-backed token bucket with INCR + EXPIRE - HC-03: DB fallback via `profe_rate_limits` table with time-window comparison - HC-05: Rate limit headers returned (`limit`, `remaining`, `reset`) - HC-13: Endpoint-specific thresholds (checkout=10/60s, admin=30/60s, webhook=200/60s) **All 23 PHP files pass `php -l`** with zero syntax errors.