Memory Wiki

Let me read all the relevant files first to understand the current content.

Let me read the rest of the T52 file to see all references to the return type and any other relevant sections.

Now I have the full picture. Let me make all the edits. **T52 edits needed:** 1. Remove the "Return Value Shape" array documentation (contradicts `: string` interface) 2. Add Google Ads SDK client construction from config credentials **T17 edits needed:** 3. Change `new \DateTimeImmutable()` to use `$session->created` in the initial upload 4. Change `new \DateTimeImmutable()` in the retry mechanism to use stored timestamp 5. Add timestamp to the retry payload Let me start with T52:

Now add the SDK client construction. I'll update the implementation section to show the constructor building the GoogleAdsClient, and the DI wiring accordingly.

Now update the FAULT-008 entry to reflect the SDK client construction:

Now let me add a test for the SDK client construction in the test table. Let me re-read the test section to insert correctly:

Now I'll add a test for SDK client construction and renumber the tests:

Let me check the formatting of the test table to make sure it's clean:

The table got extra pipes. Let me fix the formatting:

Let me fix the module test numbering — they still say 15-18 but should be 16-19 now:

Now update the verification step that mentions "all 18 tests":

Now let me fix T17. I'll address all the timestamp issues: 1. **Initial upload** — use `$session->created` instead of `new \DateTimeImmutable()` 2. **Retry payload** — store the timestamp so retries use the same dedup key 3. **Retry call** — use stored timestamp from payload

Now let me update the retry enqueue call to pass the timestamp in the payload. Let me check the current enqueue call:

Now update the enqueue call to pass the timestamp:

Now update the `conversion_payload` column definition to include the timestamp, and update the retry processing to use it:

Now update the retry processing to use the stored timestamp from payload:

Let me check if there's an `enqueueConversionRetry` method defined in the T17 file:

Let me add the `enqueueConversionRetry` method definition to show how it stores the timestamp:

Now I need to add the `storeConversionRetry` repository method. Let me check the repository section in T17:

Now update the test table in T17 to reflect the timestamp change. Let me check the test section:

Let me add a test for the timestamp in the retry payload, and update the retry processing test:

Let me add an integration test for the retry timestamp persistence:

Let me do a final verification by reading the key sections of both files:

Let me verify the final state of both files' key sections more thoroughly:

Found one more inconsistency — FAULT-005 still says 18 tests:

Let me add a verification step for the SDK client construction:

All three issues are now fixed. Here's a summary of everything I changed: --- ## Summary of Changes ### T52 Fixes (`/root/.hermes/plans/task-t52-build-plan.md`) **Issue 1: Return type contradiction (T52-01)** - Removed the "Return Value Shape" section (§3) that showed `uploadConversion()` returning an array `['success' => true, 'conversion_id' => '...']` - Replaced with a clarifying note confirming the method returns `string` (the Google Ads conversion resource name), matching the `: string` interface declaration - The implementation already correctly returns `$result->getConversionResourceName()` — no interface change needed **Issue 2: SDK client construction missing (T52-02)** - Added "Constructor & SDK Client Construction" subsection in §9 showing how `GoogleAdsClient` is built from config credentials: - `OAuth2TokenBuilder` consuming client_id, client_secret, refresh_token - `GoogleAdsClientBuilder` consuming developer_token, login_customer_id - Updated FAULT-008 to acknowledge the SDK client is built from config - Added test 3: `testConstructBuildsGoogleAdsClient` — verifies non-null `GoogleAdsClient` instance - Renumbered tests 3→4 through 18→19; updated all test count references (FAULT-005, verification steps) - Added verification step 4 for client construction ### T17 Fixes (`/root/.hermes/plans/task-t17-conversion.md`) **Issue 3: Timestamp source (T17-01)** - Changed `conversionDateTime: new \DateTimeImmutable()` to: ```php $conversionDateTime = \DateTimeImmutable::createFromFormat('U', (string) $session->created) ?: new \DateTimeImmutable(); ``` - Captured the timestamp **before** the try block so it's available for both the initial call and the retry enqueue - Updated `enqueueConversionRetry()` call to pass `$conversionDateTime` as the 6th argument - Added `enqueueConversionRetry()` method definition showing the timestamp stored in JSON payload as `conversion_date_time` - Updated `processConversionRetries()` to read the stored `conversion_date_time` from payload and use it for retry uploads instead of `new \DateTimeImmutable()` - Added `storeConversionRetry()` repository method to persist payload with timestamp - Updated `conversion_payload` column comment to include `conversion_date_time` - Added test 11: `testStoreConversionRetryPersistsTimestamp()` — verifies timestamp round-trip through repository - Updated FAULT-005 from 10 to 11 new tests - Updated test 6 and 7 descriptions to reference session timestamp usage