Memory Wiki

Let me start by reading all the build briefs and current source files to understand what needs to change.

Let me continue reading all the source files that need modification.

Now I have a clear picture. Let me check the StripeServiceInterface to understand available methods, then start implementing all fixes.

Now I have a clear picture of all issues. Let me read StripeService.php to understand how to fix the direct SDK call in handleInvoicePaid.

Now I have full understanding of all the changes needed. Let me implement them systematically. **Starting with T17 fixes:** Fix 1: WebhookHandlerModule.php - the `catch(\Throwable)` at line 209-214 returns 200, must return 500. Fix 2: WebhookHandler.php - catch(Throwable) in uploadConversionToGoogleAds() needs retry. Fix 3: WebhookHandler.php - replace `\Stripe\Subscription::retrieve()` with StripeService. Need to add `retrieveSubscription()` to StripeService.

Now Fix 3 - replace the direct SDK call with StripeService. First, add `retrieveSubscription` to StripeServiceInterface and StripeService.

I accidentally added an extra method. Let me fix the interface to only add `retrieveSubscription`.

Good, interface is clean. Now add the implementation to StripeService.php and fix the WebhookHandler.

Now update WebhookHandler.php to use StripeService::retrieveSubscription instead of direct SDK call.

T17 fixes complete. Now T52 - remove dead catch/rethrow in GoogleAdsConversionService.

Now fix T52 tests. I need to add proper assertions and enhanced_conversions=false test.

Now T15 fixes. First, let me fix StripeServiceTest.php - remove false-positive tests (reflection-based private method calls and try/catch-all patterns).

Now fix CheckoutService.php - add preg_match validation to GET gclid fallback.

Now add the test for invalid GCLID in URL to CheckoutServiceTest.php.

All changes implemented. Now let me verify with the checks from the task.

There's a syntax error. Let me check the file around line 372.

I see the issue - line 372 has double backslash causing a syntax error. Let me fix it.

Now check the module file for the same issue and re-verify all files.

The module file also has double backslash issues. Let me fix them.

Let me also check the GoogleAdsConversionService for the same backslash issue.

Now let me re-run syntax checks on all modified files.

All syntax OK. Now check for namespace separator issues.

All namespace checks pass. Let me do a final review of the key changes in each file.

Let me do one final check - verify the CheckoutService gclid regex fix.

All changes verified. Here's the complete summary: ## Summary of Changes ### T17 — WebhookHandler (CRITICAL) **Files modified:** 1. **`/root/profe-modules/webhook_handler/src/WebhookHandler/WebhookHandlerModule.php`** (Fix 1) - Changed the `catch(\Throwable)` in `handleStripeWebhook()` from returning HTTP 200 `['success' => true]` to returning HTTP 500 with error message. This ensures Stripe retries the webhook on unexpected errors instead of silently accepting it and losing the event. 2. **`/root/profe-modules/webhook_handler/src/WebhookHandler/WebhookHandler.php`** (Fix 2 + 3) - **Fix 2:** Added `$this->enqueueConversionRetry(...)` call in the `catch(Throwable)` block of `uploadConversionToGoogleAds()`. Previously, only `GoogleAdsConversionException` triggered a retry — unexpected errors (RuntimeException, TypeError, etc.) were only logged, causing permanent data loss. - **Fix 3:** Replaced `\Stripe\Subscription::retrieve($invoice->subscription)` with `$this->stripeService->retrieveSubscription($invoice->subscription)`. No more direct Stripe SDK calls from the webhook handler. 3. **`/root/profe-modules/stripe_service/src/StripeService/StripeServiceInterface.php`** (Fix 3 support) - Added `retrieveSubscription(string $subscriptionId): \Stripe\Subscription` method declaration. 4. **`/root/profe-modules/stripe_service/src/StripeService/StripeService.php`** (Fix 3 support) - Implemented `retrieveSubscription()` — wraps `\Stripe\Subscription::retrieve()` with proper error handling, keeping the SDK abstraction layer intact. ### T52 — Google Ads Conversion (HIGH) **Files modified:** 5. **`/root/profe-modules/google_ads_conversion/src/GoogleAdsConversion/GoogleAdsConversionService.php`** (Fix 1) - Removed the dead `catch (GoogleAdsConversionException $e) { throw $e; }` block. This was a no-op catch/rethrow that provided no value. 6. **`/root/profe-modules/google_ads_conversion/tests/Unit/GoogleAdsConversionServiceTest.php`** (Fix 2 + 3) - **Fix 2:** Enhanced `testUploadConversionReturnsResourceNameOnSuccess()` and `testUploadConversionAcceptsHashedEmail()` to assert the actual MD5 hash of gclid+datetime in the returned resource name. - Added `testUploadConversionDifferentGclidYieldsDifferentHash()` — verifies different GCLIDs produce different resource names. - **Fix 3:** Added `testUploadConversionEnhancedConversionsDisabledDoesNotThrow()` — configures `enhanced_conversions=false` and verifies the service doesn't throw when hashed email is provided. ### T15 — StripeService / CheckoutService (CRITICAL) **Files modified:** 7. **`/root/profe-modules/stripe_service/tests/Unit/StripeServiceTest.php`** (Fix 1 + 2) - **Fix 1:** Removed 5 false-positive tests that called private methods via reflection (`isLiveMode`, `getPriceId`, `createCustomer`). - **Fix 2:** Removed 5 false-positive tests using `try/catch-all` with `$this->assertNotEmpty($e->getMessage())` patterns (`createCheckoutSessionReturnsSessionData`, `createBillingPortalReturnsUrl`, `createCheckoutSessionHostedDefault...`, `createCheckoutSessionWithMetadata...`, `createCheckoutSessionEmbeddedMode...`). - Kept all valid tests that use real assertions: `testImplementsInterface`, `testConstructWithValidConfig`, `testCreateCheckoutSessionThrowsForNonExistentUser` (x2), `testGetSubscriptionReturnsNull...`, `testGetSubscriptionReturnsRecord...`, `testVerifyWebhookSignatureThrowsWhenNoSecret...`, `testCreateCheckoutSessionInterfaceHasUiModeParam`. - Added `testGetWebhookSecretMethodExists()` and `testGetWebhookSecretReturnsConfiguredValue()` per build brief spec. 8. **`/root/profe-modules/checkout_service/src/CheckoutService/CheckoutService.php`** (Fix 3) - Added `preg_match('/^[a-zA-Z0-9_-]+$/', $gclid)` validation to the GET `gclid` fallback path. Previously only `trim()` was applied, allowing malformed/malicious values through. 9. **`/root/profe-modules/checkout_service/tests/Unit/CheckoutServiceTest.php`** (Fix 3) - Added `testCreateSessionGclidFromUrlFallback()` — verifies valid GCLID from `$_GET` is passed through to StripeService metadata. - Added `testCreateSessionGclidFromUrlRejectsInvalid()` — verifies malformed GCLID (XSS attempt `<script>alert(1)</script>`) is rejected and not passed in metadata. ### Verification Results - **PHP syntax check:** All 10 modified files pass `php -l` - **Quadruple backslash check:** `grep -rn '\\\\\\\\'` shows no issues in any module's `src/` directory