Memory Wiki

I'll start by reading all the context material to understand the requirements thoroughly.

Now let me read the T11 build plan format and examine the existing code:

Let me look at the existing code files to understand the current implementations:

Now let me read the remaining files:

Let me also check the existing migrations and test files:

Let me check the count of test methods in each module:

Now I have full context. All 4 modules already have ≥12 tests (21, 17, 27, 18 respectively), but the briefs will incorporate FAULT-013 through FAULT-017 fixes as applicable. Let me create all 4 build briefs now.

T21 done. Now creating T22 (Mail Queue):

T22 done. Now creating T23 (Email Templates):

T23 done. Now creating T24 (Email Admin):

Let me verify all 4 files exist:

All 4 build briefs are created. Here's the summary: --- ## Summary: What I Did ### Files Created 1. **`/root/.hermes/plans/task-t21-build-plan.md`** (19.6 KB) — Brevo Service 2. **`/root/.hermes/plans/task-t22-build-plan.md`** (22.7 KB) — Mail Queue 3. **`/root/.hermes/plans/task-t23-build-plan.md`** (23.5 KB) — Email Templates 4. **`/root/.hermes/plans/task-t24-build-plan.md`** (14.7 KB) — Email Admin ### Fault Incorporation Summary | Fault | Description | T21 | T22 | T23 | T24 | |-------|-------------|-----|-----|-----|-----| | **FAULT-013** | Webhook signature verification | ✅ Fix: call `verifyWebhookSignature()` in `handleBrevoWebhook()` before processing; return 401 on mismatch | N/A | N/A | N/A | | **FAULT-014** | Missing `wp_mail()` override | N/A | ✅ Fix: new `WpMailOverride` class hooking `phpmailer_init`; register in `MailQueueModule::boot()` | N/A | N/A | | **FAULT-015** | Template seed data missing | N/A | N/A | ✅ Fix: new `V002__SeedEmailTemplates` migration inserting 27 templates (15 transactional, 5 campaign, 7 system) | N/A | | **FAULT-016** | Zero test coverage | ✅ Verified 21 existing tests; add 4 new for sig verification (target: 25+) | ✅ Verified 17 existing tests; add 5 new for WpMailOverride (target: 22+) | ✅ Verified 27 existing tests; add 4 new for seed migration (target: 31+) | ✅ Verified 18 existing tests; add 2 new for FAULT-017/FAULT-002 (target: 20+) | | **FAULT-017** | Duplicate exception files | ✅ Fix: remove top-level `BrevoServiceException.php`; keep `Exception/` subdir; update imports | ✅ Fix: remove top-level `MailQueueException.php`; keep `Exception/` subdir; update imports | ✅ Fix: remove top-level `EmailTemplateException.php`; keep `Exception/` subdir; update imports | ✅ Fix: remove top-level `EmailAdminException.php`; keep `Exception/` subdir; update imports | ### Additional Faults Cross-Referenced - **FAULT-001** (price_amount comment) — Not applicable to Module 4 (no DECIMAL price columns) - **FAULT-002** (direct `profe_users` queries) — Documented as workaround in T21 (`BrevoService.php`), T22 (`MailQueue.php`), T24 (`EmailAdminRepository.php`) - **FAULT-004** (CSRF enforcement) — Already implemented in all 4 modules via `checkAdminAccessWithCsrf()` calling `requireValidNonce()` - **FAULT-006** (missing migration PHP classes) — All migrations already have PHP classes - **FAULT-007** (undocumented profe_users queries) — Fixed via FAULT-002 workaround comments - **FAULT-008** (dependencies not injected) — All 4 modules verified: constructor injection matches declared dependencies - **FAULT-011** (backslash issue) — Audit step included in all 4 briefs ### Key Findings 1. **All 4 modules already have ≥12 tests** — T21 has 21, T22 has 17, T23 has 27, T24 has 18. The briefs expand coverage further for the fault fixes. 2. **FAULT-013 fix location:** `BrevoServiceModule::handleBrevoWebhook()` — extract `brevo-signature` header, load `brevo.webhook_secret` from config, verify via `BrevoApiClient`, reject with 401 on failure. 3. **FAULT-014 approach:** `phpmailer_init` hook (cleaner than pluggable function override). Intercept PHPMailer, enqueue via `MailQueueInterface::enqueueToEmail()`, clear recipients to prevent WordPress native send. 4. **FAULT-015 seed data:** All 27 template IDs, names, categories, and required variables are documented per PB Appendix B. 5. **FAULT-017 clean-up:** Each module keeps only `src/{Module}/Exception/{Module}Exception.php` and removes the top-level duplicate.