Memory Wiki

Untitled Session

2026-05-25 05:17 UTC · 5 messages · cli

You2026-05-25 05:17 UTC
Review ALL 7 tasks for Module 7 (Community) — final GS Code Review before Pushed to Staging. ## Sources - **Build briefs:** /root/.hermes/plans/task-t36/t37/t38/t39/t40/t41/t42-build-plan.md - **Project Brief:** /root/.hermes/plans/pb-m7-community.md - **TA Code Review:** /root/.hermes/plans/ta-code-review-t36-t42.md - **Past Faults Log:** /root/.hermes/plans/past-faults-log.md ## Code directories - /root/profe-modules/community_spaces/ — T36 - /root/profe-modules/content_engine/ — T37 - /root/profe-modules/comment_system/ — T38 - /root/profe-modules/badge_system/ — T39 - /root/profe-modules/leaderboard/ — T40 - /root/profe-modules/document_library/ — T41 - /root/profe-modules/moderation_handler/ — T42 ## What to check per task 1. **PHP syntax** — All files pass `php -l` 2. **ModuleInstanceInterface** — Each Module.php has getName, getDependencies, register, boot, shutdown 3. **FAULT-011** — No quadruple backslash (`\\\\\\\\` → grep for `\\\\\\\\\\\\\\\` or 8 backslashes in source). Correct pattern is `\\\\\\\\` (4 backslashes in source = 2 at runtime = 1 namespace separator) 4. **Migration SQL** — Has `-- UP` and `-- DOWN` markers 5. **CSRF** — Admin mutation endpoints use checkAdminAccessWithCsrf() or requireValidNonce() 6. **HA-03 (Hard Check)** — All PDO queries use prepared statements 7. **Interface matches brief** — Method signatures match ## Output Write to /root/.hermes/plans/gs-code-review-t36-t42.md. Per task: **GREENLIGHT** — All checks pass, code is correct **REDLIGHT** — Blocking issues, list each with file path, line number, and severity Overall verdict for Module 7: READY FOR STAGING or NEEDS REWORK.
Donna2026-05-25 05:17 UTC
I'll start by reading all the source documents and then systematically review each of the 7 modules. Let me load everything in parallel.
Tool2026-05-25 05:17 UTC
{"content": " 1|# Project Brief: Module 7 — Community\n 2|\n 3|**Document ID:** PB-M7-COMMUNITY-001\n 4|**Author:** SA\n 5|**Date:** 2026-05-25\n 6|**Status:** DRAFT\n 7|**Build Plan Source:** pb-complete.md (lines 746-833)\n 8|\n 9|---\n 10|\n 11|## §0 Exec...
Tool2026-05-25 05:17 UTC
{"content": " 1|# TA Code Review — Module 7 (Community) Tasks T36–T42\n 2|\n 3|**Date:** 2026-05-25 \n 4|**Reviewer:** TA \n 5|**Scope:** All 7 Module 7 tasks against their build briefs\n 6|\n 7|---\n 8|\n 9|## T36 — Community Spaces (KEEP, existing code)\n 1...
Tool2026-05-25 05:17 UTC
{"content": " 1|# Past Faults Log — Profe Core Modules\n 2|\n 3|> **Purpose:** Every bug, design miss, and edge case discovered during development is recorded here.\n 4|> Future modules (and future TBs) MUST read this log before writing code.\n 5|\n 6|---\n 7|\n 8|## ...