Memory Wiki

Sweep the entire Profe codebase for gremlin breeding grounds. Write findings to /root/.hermes/plans/. Work in parallel with GS (separate subagent). Both of you submit independent reports. ## What to hunt ### Silent Failures - Empty catch blocks that swallow errors - Code that runs but has no side effects (writes nobody reads) - Events emitted with no registered listeners - Methods that log errors but never surface them (no admin alert, no retry) - Migration steps that silently skip (IF NOT EXISTS on everything means you'd never know if a migration failed) ### Dead Code Paths - Interface methods with zero callers across all modules - Routes registered but no frontend or webhook will ever hit them - Config keys defined in the build brief but never read at runtime - Constructor parameters stored but never used in the class ### Assumptions That Don't Hold - "The user is always logged in" — routes with `permission_callback => '__return_true'` that assume the handler won't crash on null user - "The table always has rows" — `getResults()` used without checking if result is empty - "This API always returns in 5 seconds" — no timeout handling on external API calls (Brevo, Stripe, Bunny) - "The config file is always there" — code that reads PROFE_MODULES_DIR without checking if it's defined ### State Leaks / Compensation Gaps - Pipeline steps with execute() but no compensate() - Stripe PaymentIntent created but user creation fails — orphan payment with no cleanup - WP user created but CRM sync fails — user exists in WP but never reaches Brevo - File uploaded to Bunny Storage but DB record creation fails — orphan file ### Missing Observability - Error paths that print to error_log() but nobody reads error logs - No admin dashboard for failed pipeline steps - No alerts for stuck cron jobs (abandoned cart scanner, CRM sync queue) - Webhook handlers that return 200 even when processing fails (Stripe will stop retrying) ### Hardcoded Environment - API URLs hardcoded in service files instead of config - Credential defaults in source code (even if just for dev) - Path assumptions (e.g., `/tmp/` for uploads — may not exist on production) - Cache TTLs, retry counts, timeouts hardcoded as magic numbers ### Interface Drift - Modules that depend on CoreUsersInterface but the interface was never updated per spec - T44 pipeline calling crm_sync with the wrong parameter type - Module 8 form admin calling Module 5 CRM with mismatched method signatures ### Auto-generated Template Artifacts - `listItems/getItem/createItem/updateItem/deleteItem` stubs that were never replaced - Generic README.md files that say "TODO: describe this module" - Composer.json files with placeholder descriptions - Test files that test the template (createItem works) but not the domain (createPost fails) ## Report format Write to /root/.hermes/plans/sa-gremlin-report.md (you're SA) Per finding: - **Category**: Silent Failure / Dead Code / Assumption / State Leak / Observability / Hardcoded / Interface Drift / Template Artifact - **File**: path + line number - **Risk**: LOW / MEDIUM / HIGH / CRITICAL - **Description**: what's wrong - **Fix**: what to do about it