Memory Wiki

Fix ALL 17 gremlin items. Write fixes to the codebase. After each fix, verify with php -l. Write a summary of what was changed. ## Priority Order (do in this order) ### CRITICAL (6 items) **1. Fix Brevo Webhook — Return HTTP 500 on Errors** File: /root/profe-modules/brevo_service/src/BrevoService/BrevoServiceModule.php Find the catch block in handleBrevoWebhook (around line 226-231) that returns ['success'=>true] with HTTP 200 on error. Change to return HTTP 500 so Brevo retries. Pattern: same as Stripe webhook handler returns 500 on processing failure. **2. Fix CSRF Nonce Enforcement — Stub is No-Op** File: /root/profe-modules/csrf_middleware/src/CsrfMiddleware/CsrfMiddlewareStub.php Replace the empty requireValidNonce() with a real implementation that calls wp_verify_nonce() and throws if invalid. Also implement generateNonce() using wp_create_nonce(). **3. Build Real CoreUsersInterface — Stop Returning Null** File: /root/profe-modules/core_users/src/CoreUsers/CoreUsersStub.php Replace stub methods with real queries against profe_users table via ProfeDB. Implement findByUuid, findByEmail, findByWpId, getAllUsers, search. **4. Build Real ConfigManager — Stop Returning Defaults** File: /root/profe-modules/config_manager/src/ConfigManager/ConfigManagerStub.php Implement a simple array-based config store that reads from a config file or env vars. Store values in a static array. get() returns from array or $default. has() checks existence. **5. Build Real EventBus — Stop Dropping Events** File: /root/profe-modules/event_bus/src/EventBus/EventBusStub.php Implement a simple in-memory event bus. emit() calls all registered listeners. on() registers a listener. Remove the "Stub" suffix — rename to EventBus or EventBusService. **6. Fix InputSanitizer Stub — Should Actually Sanitize** File: /root/profe-modules/input_sanitizer/src/InputSanitizer/InputSanitizerStub.php Implement real sanitization: strip_tags for string, filter_var for email, wp_kses for HTML, validate as appropriate. ### HIGH Items (remaining) **7. Fix Duplicate Migration Version Numbers** In /root/profe-modules/migrations/, find all duplicate version pairs. Rename the community versions (045-052) to unique numbers (058-065). Update migration PHP classes to match. **8. Fix Empty Catch in StripeService.resolveUuidFromCustomer()** File: /root/profe-modules/stripe_service/src/StripeService/StripeService.php around line 611 Replace empty catch with error_log + return null. **9. Fix SyncCrmStep — Silently Swallows CRM Errors** File: /root/profe-modules/form_entries/src/FormSubmissions/Pipeline/Steps/SyncCrmStep.php Log the error, set step result to failed, don't return success. **10. Fix Pipeline Order — Payment Before User Creates Orphan PaymentIntents** Swap the order of ProcessPaymentStep and CreateWpUserStep in the pipeline registration at FormSubmissionsModule.php **11. Write Unit Tests for Pipeline Steps** Create test files for the 9 pipeline step classes. At minimum 1 test per step class. **12. Build Admin Dashboard for Failed Pipeline Steps** Not a code fix — log this finding for future. Skip for now. **13. Add Tests for Core Modules** Not urgent — log for future. Skip for now. **14. Fix Duplicate Community Migration Version Numbers (045-052)** Same as #7 above. **15. Fix StripeWebhookHandler — Type Confusion + Missing Idempotency + Dead Route** Fix the type confusion (line 113). Add idempotency check. Don't worry about the dead route for now. **16. Move Direct SQL Queries to Repository Layer** This is a large refactor across 7+ service files. Create repository methods and update service files. **17. Fix CreateMemLevelFeaturesMigration — Wrong SQL File + Missing Interface** Fix the migration class to read the correct SQL file and add implements MigrationInterface. ## Output Write a summary of all changes made to /root/.hermes/plans/tb-fixes-log.md